search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
413 stars 184 forks source link

CI: Do not install aiida-core in editable mode #6369

Closed danielhollas closed 2 months ago

danielhollas commented 2 months ago

Follow up from discussion in #6363 Let's see if this works, I don't see why it shouldn't...

danielhollas commented 2 months ago

Huh, looks like this fails for the pre-commit run, interesting... cc @sphuber

sphuber commented 2 months ago

Huh, looks like this fails for the pre-commit run, interesting... cc @sphuber

Seems this may be related https://github.com/python/mypy/issues/13392 It is about setuptools though, but it might very well also impact flit. Haven't found the solution yet though. But if it requires other workarounds, we might as well keep the editable install 😅 it is not as though it has a huge drawback

sphuber commented 2 months ago

So I think we can close this, right @danielhollas ?