search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

Devops: Add the `slurm` service to nightly workflow #6372

Closed sphuber closed 5 months ago

sphuber commented 5 months ago

The nightly worklow is configuring a computer that is using the core.slurm scheduler plugin, however, the container did not have a SLURM service running.

danielhollas commented 5 months ago

@sphuber I am wondering, shouldn't some of those warnings / errors fail the workflow?

sphuber commented 5 months ago

@sphuber I am wondering, shouldn't some of those warnings / errors fail the workflow?

Perhaps. It is just that the nightly workflow just borrows the setup script with the main test workflow, but then it only executes a subset of tests, and these don't rely on this SLURM computer. So it failing didn't really matter either. If SLURM wouldn't have been installed for the container that runs the main tests, the tests would have errored because the computer would not be able to SLURM.