search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
413 stars 185 forks source link

Devops: Update deprecated `whitelist_externals` option in tox config #6380

Closed agoscinski closed 2 months ago

agoscinski commented 2 months ago

The option whitelist_externals is deprecated in tox with version 3.18 (Release Jul 23, 2020). The option allowlist_externals is used since 3.18.

sphuber commented 2 months ago

I notice that this effectively introduces a lower version requirement for tox but we don't currently specify tox as a (dev) dependency anywhere. I don't use it myself, but I guess this means we should maybe add tox~=3.18 to the pre-commit optional dependencies in pyproject.toml, right?

agoscinski commented 2 months ago

Pinned minversion 3.18.0 for tox (see doc here https://tox.wiki/en/4.15.0/config.html#core)