aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

CI: Do not install aiida-core in editable mode #6394

Closed danielhollas closed 4 months ago

danielhollas commented 4 months ago

AFAIK there's no reason to install aiida-core in editable mode in CI. Followup on #6363

danielhollas commented 4 months ago

huh, interesting. pre-commit / mypy are very unhappy about this.

sphuber commented 4 months ago

It probably has to do with the fact that the file exclusion rules in .pre-commit-config.yaml are no longer respected.

danielhollas commented 4 months ago

Ouch, okay thanks. I will not have time to pursue this further, feel free to close this.

danielhollas commented 3 months ago

AFAIK there's no reason to install aiida-core in editable mode in CI.

FYI @sphuber AIFO (as I found out), editable mode is in fact needed for collecting code coverage. :-)