search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

GHA: Docker build refactor #6396

Closed danielhollas closed 4 months ago

danielhollas commented 4 months ago

This is an analogous refactor that I did over at aiidalab-docker-stack, please see that PR for details. https://github.com/aiidalab/aiidalab-docker-stack/pull/439

tl;dr This should both increase speed and robustness of the build, main due to:

  1. Not uploading image as artifacts. (this does have a side-effect that the build can't happen from forks, maybe we can workaround that)
  2. Build multiplatform images together
danielhollas commented 4 months ago

@unkcpz This is ready for review. I'd suggest to merge this to get the docker build fixed, and deal with the issues of forks in subsequent PR.

unkcpz commented 4 months ago

I'd suggest to merge this to get the docker build fixed, and deal with the issues of forks in subsequent PR

Sure, I’ll review it.

Sent from Outlook for iOShttps://aka.ms/o0ukef

From: Daniel Hollas @.> Sent: Wednesday, May 22, 2024 4:23:58 AM To: aiidateam/aiida-core @.> Cc: Jusong Yu @.>; Mention @.> Subject: Re: [aiidateam/aiida-core] GHA: Docker build refactor (PR #6396)

@unkcpzhttps://github.com/unkcpz This is ready for review. I'd suggest to merge this to get the docker build fixed, and deal with the issues of forks in subsequent PR.

— Reply to this email directly, view it on GitHubhttps://github.com/aiidateam/aiida-core/pull/6396#issuecomment-2123751634, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDMFROBVSEUUQ42X4IPSC3ZDP6T5AVCNFSM6AAAAABHZUMFOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTG42TCNRTGQ. You are receiving this because you were mentioned.Message ID: @.***>

danielhollas commented 4 months ago

Hmm, after merging main the builld failed. Will have a look.

danielhollas commented 4 months ago

@unkcpz hmm, the warp arm64 runner doesn't seem to pick up the job. Do you need to somehow activate the trial period?

image

danielhollas commented 4 months ago

@sphuber this is ready to merge.

sphuber commented 4 months ago

The Docker Images / test-amd64 build is failing. Is this expected and of any concern?

danielhollas commented 4 months ago

@sphuber I restarted the test and it passed. It seems to be somewhat flaky, not sure why. I suspect sometimes the image download stalls for some reason (I blame GHA). We should keep an eye on how often it happens, and whether we need to investigate further.