search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

CLI: Raise if no root node specified in `verdi node graph generate` #6405

Closed sphuber closed 4 months ago

sphuber commented 4 months ago

Fixes #6397

The root_node positional argument was recently made optional since it was deprecated and replaced by the -N/--nodes option. However, the change forgot to check that at least one root node is specified. Not specifying any would result in an exception.

sphuber commented 4 months ago

Labeling as blocking since this bug was introduced by changes that have not yet been released

sphuber commented 4 months ago

Thanks for the review @agoscinski but given the responses on the discourse thread it seems like we would rather be going with a different solution, as implemented in https://github.com/aiidateam/aiida-core/pull/6427 If you have the time to review that, that would be great.

sphuber commented 4 months ago

Superseded by #6427