search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
412 stars 184 forks source link

Adds output `verdi process [show|report|status|watch|call-root]` subcommands #6428

Closed agoscinski closed 3 weeks ago

agoscinski commented 1 month ago

Fixes https://github.com/aiidateam/aiida-core/issues/6391

Also because it became apparent during the PR that verdi process watch does not have the --most-recent-node option, so I added it. There is no test testing the functionality (only the error), because before there were no test for process watch (they might be somewhere else, because this look like rabbitmq related logic).

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (ef60b66) to head (edde64d). Report is 39 commits behind head on main.

Files Patch % Lines
src/aiida/cmdline/commands/cmd_process.py 81.82% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6428 +/- ## ========================================== + Coverage 77.51% 77.83% +0.33% ========================================== Files 560 561 +1 Lines 41444 41789 +345 ========================================== + Hits 32120 32523 +403 + Misses 9324 9266 -58 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-core/pull/6428/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [presto](https://app.codecov.io/gh/aiidateam/aiida-core/pull/6428/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `73.13% <47.83%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sphuber commented 3 weeks ago

@agoscinski also please update the branch and address the conflict

agoscinski commented 3 weeks ago

Please don't squash, tried to separate the commits meaningful

sphuber commented 3 weeks ago

The tests-presto workflow failed. This is due to the test for verdi process watch which requires a broker, but the test profile for tests-presto intentionally doesn't define it. I have fixed it by marking that test with pytest.mark.requires_rmq.