search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
411 stars 184 forks source link

CLI: Deprecate accepting `0` for `default_mpiprocs_per_machine` #6440

Closed sphuber closed 3 weeks ago

sphuber commented 4 weeks ago

Fixes #4225

The verdi computer setup command would accept the value 0 for the default_mpiprocs_per_machine input. This was added as a value for users to indicate as to not set a value for the property. But the CLI has the ! marker for this purpose. The ComputerBuilder converts the 0 to None but this conversion now raises a deprecation warning.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.70%. Comparing base (ef60b66) to head (67117fa). Report is 17 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6440 +/- ## ========================================== + Coverage 77.51% 77.70% +0.20% ========================================== Files 560 562 +2 Lines 41444 41718 +274 ========================================== + Hits 32120 32412 +292 + Misses 9324 9306 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.