Bring docker CI tests back for PRs from forked repo

aiidateam / aiida-core

The official repository for the AiiDA code

https://aiida-core.readthedocs.io

Other

411 stars 184 forks source link

Bring docker CI tests back for PRs from forked repo #6449

Closed unkcpz closed 3 weeks ago

unkcpz commented 3 weeks ago

https://github.com/aiidateam/aiida-core/pull/6396 refactoring docker CI by not upload the artifact but directly push image to ghcr.io registry, which accelerate the CI time a lot. However, push to ghcr.io requires the write permission of GITHUB_TOKEN which is not available for the PR from forked repo. Thus it unfortunately cut the feature to have the built image tested from forked repo which can grab some issue as manifested and fixed in https://github.com/aiidateam/aiida-core/pull/6445

sphuber commented 3 weeks ago

@unkcpz If you implement this, would that make #6446 obsolete?

unkcpz commented 3 weeks ago

Yes, but I may not able to do it now. So maybe finish #6446 and keep this issue open?