Open agoscinski opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.86%. Comparing base (
ef60b66
) to head (90312f8
). Report is 30 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@agoscinski FYI One another improvement that I wanted to do but did not get to is to make graphviz
dependency optional i.e. to automatically skip tests that need it if it is not available. We already do this for other external optional dependencies (e.x. xcrysden et al).
The problem with the current tox test environments is that they do require psql database which require a service running in the background. With the merge of #6425, we can use the sqlite backend to run tests more encapsulated with less dependencies on global configurations.
I still need to figure out how to set up a ssh config in a virtual-environment-friendly way. We could just run the
.github/workflow/setup_ssh.sh
file, but then it messes too much with existing ssh configuration. One could add an include in${HOME}/.ssh/config
to include another config file that is stored locally in the tox environment.This just adds one line to the user config, that only works inside the tox environment. So does not have any effect outside of the environment to the functionality of ssh.