search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
411 stars 184 forks source link

Make ssh channel timeout configurable for exec_command_wait_bytes #6452

Closed unkcpz closed 3 weeks ago

unkcpz commented 3 weeks ago

fixes #6377

Just make it configurable, not changing behavior. In aiida-hyperqueue, we call the exec_command_wait_bytes directly. It seems the only use case at the moment that need this.

The changes is test from branch v2.5.1 the production environment I used, so it would be nice if it can backported to support/2.5.x

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.86%. Comparing base (c4afdd0) to head (5ae1dbc). Report is 117 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6452 +/- ## ========================================== + Coverage 77.73% 77.86% +0.14% ========================================== Files 548 562 +14 Lines 40221 41794 +1573 ========================================== + Hits 31260 32539 +1279 - Misses 8961 9255 +294 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-core/pull/6452/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [presto](https://app.codecov.io/gh/aiidateam/aiida-core/pull/6452/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `73.19% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

unkcpz commented 3 weeks ago

Since v2.6 is right around the corner, would you really need a patch release?

I'd say so, I want to stick to 2.5.x as production environment (which is almost flawless for my use case, if I ignore the caching problem) to finalize the SSSP running, otherwise there may be more issues coming up for the new minor version.