Closed sphuber closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.87%. Comparing base (
ef60b66
) to head (19cbf11
). Report is 34 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review @GeigerJ2
Hi guys, again sorry for being a late party-pooper. My main question is if we want to add these RabbitMQ-specific options to all of the setup commands. Now that we have a command for reconfiguring rabbitmq, can't we just use the defaults and then point the user to this command in case they want to use others?
I think we already foresee that we want to try and add a different broker than RabbitMQ. Presumably the options for this broker might be different. Are we going to add all the options for that broker here as well? Should we then also rename the rabbitmq options? (which are now all --broker-X
).
I would stick with just adding --use-rabbitmq
/ --no-use-rabbitmq
, use the defaults for the configuration, add a check to see if it worked and point them to the configure-rabbitmq
command if it failed.
The
verdi profile setup
command was added to replace the deprecated commandverdi setup
. The new command dynamically generates a subcommand for each installed storage plugin.However, the new command did not allow to configure the connection parameters for the RabbitMQ broker, unlike
verdi setup
. These common options are now added to the subcommands.In addition, a new option is added
--use-rabbitmq/--no-use-rabbitmq
. This flag is on by default, to keep the old behavior ofverdi setup
. When toggled to--no-use-rabbitmq
, the RabbitMQ configuration options are no longer required and are also not prompted for. The profile is then configured without a broker.