aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
411 stars 184 forks source link

Implement optional version argument into VerdiCommand that specifies when a deprecated command is removed #6463

Open agoscinski opened 3 weeks ago

agoscinski commented 3 weeks ago

Is your feature request related to a problem? Please describe

In PR https://github.com/aiidateam/aiida-core/pull/6426 we implemented into the deprecation command decorator the version argument that allows to specify with which version a command is removed from the code base. But since the deprecation command decorator became deprecated (see replacement PR https://github.com/aiidateam/aiida-core/pull/6433, see deprecation PR https://github.com/aiidateam/aiida-core/pull/6461) we did not need it. I kept the feature in a backup PR https://github.com/aiidateam/aiida-core/pull/6462 to implement it properly in aiida.cmdline.groups.VerdiCommand.

Describe the solution you'd like

Most likely we need a new input argument in aiida.cmdline.groups.VerdiCommand that specifies the version of removal, but I keep the design as open to discuss.