search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
411 stars 184 forks source link

Revert "Trasnport : ssh : copy(some.directory,recursive=False) is not… #6484

Closed khsrali closed 1 week ago

khsrali commented 1 week ago

This reverts commit ffd7809d5ed1037ea9b3756c1ae340ec478bafc1.

Sorry,... It was a mistake wanted to push to my fork, but since I've changed upstream before, it went directly to aiidateam/aiida-core. Didn't mean to.

Can someone check why branch protection doesn't work? I thought only @sphuber could puch to the main branch..

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.76%. Comparing base (ef60b66) to head (bcf1c00). Report is 53 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6484 +/- ## ========================================== + Coverage 77.51% 77.76% +0.26% ========================================== Files 560 561 +1 Lines 41444 41781 +337 ========================================== + Hits 32120 32486 +366 + Misses 9324 9295 -29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sphuber commented 1 week ago

I have fixed the problem directly by removing the commit and force pushing. If anyone has pulled since, you have to reset your branch (or also manually delete that commit) to update.

@khsrali you are part of the https://github.com/orgs/aiidateam/teams/core team, which gives anyone the right to push to main apparently. image

Not sure if there is a way we can disable that. It seems to be added automatically. I added the restriction for force pushing (only allowing it for myself, as I had to do in this case to restore the mistake), but since you did a simple fast-forward push, you didn't need a force push.