aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
431 stars 187 forks source link

Daemon: Fix `DbLogHandler` not being configured #6491

Closed sphuber closed 3 months ago

sphuber commented 3 months ago

Processes run through the daemon would no longer have their log messages attached to the database. This would result in verdi process report returning nothing.

The problem is that the start_worker function would call configure_logging without setting with_orm=True and so the DbLogHandler would essentially be undone. An integration test is added as a regression test.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.79%. Comparing base (ef60b66) to head (f17763e). Report is 115 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6491 +/- ## ========================================== + Coverage 77.51% 77.79% +0.29% ========================================== Files 560 561 +1 Lines 41444 41802 +358 ========================================== + Hits 32120 32516 +396 + Misses 9324 9286 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.