search

aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
436 stars 191 forks source link

Allow a memory specification of zero for the SLURM plugin #6605

Closed ConradJohnston closed 2 weeks ago

ConradJohnston commented 3 weeks ago

In SLURM memory specification, a value of zero is treated as a special case indicating that no memory limit should be used. This is documented here under the '--mem' section.

Currently the SLURM plugin demands a positive integer, but this logic puts an unexpected limitation on the SLURM plugin. This commit changes this logic to allow a value of 0 to be acctepted.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.88%. Comparing base (ef60b66) to head (47f83b9). Report is 128 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6605 +/- ## ========================================== + Coverage 77.51% 77.88% +0.38% ========================================== Files 560 567 +7 Lines 41444 42120 +676 ========================================== + Hits 32120 32802 +682 + Misses 9324 9318 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ConradJohnston commented 3 weeks ago

I think @giovannipizzi wrote the SLURM plugin, in time immemorial.