Open unkcpz opened 1 week ago
Attention: Patch coverage is 82.92683%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 77.90%. Comparing base (
ef60b66
) to head (ec71c9f
). Report is 133 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Exposing it as API under aiida module directly can make a bunch of LSP happy.
Out of curiosity, which LSPs specifically are you talking about?
The load_profile
is exposed from aiida
package. The __all__
attribute influences only the star imports (from aiida import *
). So I don't understand why an LSP should complain.
https://docs.python.org/3/tutorial/modules.html#importing-from-a-package
Out of curiosity, which LSPs specifically are you talking about?
The load_profile is exposed from aiida package. The all attribute influences only the star imports (from aiida import *). So I don't understand why an LSP should complain.
I use basedpyright
, and I think it is also good to have a list of what APIs we are going to exposed explicitly in all, besides make LSP happy.
fixes #6608
load_profile()
is widely used and documented. Exposing it as API under aiida module directly can make a bunch of LSP happy.