Open unkcpz opened 1 week ago
Attention: Patch coverage is 89.90826%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 77.91%. Comparing base (
ef60b66
) to head (0d87b9b
). Report is 135 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Hi @sphuber, it would be great if you can have a look at the changes. This touch the part that might break users' environment.
The problem is found when I worked on #6609. If the import of
DAEMON_DIR
moved to outside the function, the global var set in module scope and in test contest will not be reset when function is loading.The goal for a better design is to reduce the use of global variable. Now it is only the
glb_aiida_config_folder
(the originalAIIDA_CONFIG_FOLDER
). Other three are derived from this one. This lower the possibility of directly access the global variable without noticing its change.