aiidateam / aiida-core

The official repository for the AiiDA code
https://aiida-core.readthedocs.io
Other
436 stars 191 forks source link

Pre-commit: exclude mypy for all tests #6639

Open unkcpz opened 7 hours ago

unkcpz commented 7 hours ago

Not worth to have strict type check by mypy for tests/* .

unkcpz commented 6 hours ago

It was from a thing I learned from Rust. It usually not recommend to use unwrap in the source code but the unwrap is extremely suitable and the right thing for tests. I think it kinds of similar for mypy to python. If the tests fail it fail, and the tests go through the "happy path" of the codes. Type checking will sometime too strict to consider beyond the "happy path". I hope it is not too aggressive.

codecov[bot] commented 6 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.90%. Comparing base (ef60b66) to head (6b65260). Report is 139 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6639 +/- ## ========================================== + Coverage 77.51% 77.90% +0.40% ========================================== Files 560 567 +7 Lines 41444 42147 +703 ========================================== + Hits 32120 32831 +711 + Misses 9324 9316 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: