Closed khsrali closed 4 months ago
Thanks a lot @agoscinski for your review, I'll wait for more comments :)
As discussed with @khsrali offline, I am fine with removing integration test by using firecrest image to mock some real response. As @khsrali pointed out, pyfirecrest
did not do it as well. But I'd suggest to still keep it in mind and open an issue to remember to bring it back with the help from CSCS people to provide a robust and easy to deploy docker-compose solution.
Attention: Patch coverage is 79.17808%
with 76 lines
in your changes missing coverage. Please review.
Project coverage is 79.94%. Comparing base (
eb7f751
) to head (7254af5
).
Files | Patch % | Lines |
---|---|---|
aiida_firecrest/transport.py | 82.25% | 55 Missing :warning: |
aiida_firecrest/scheduler.py | 61.81% | 21 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
aiida-core
,pyfirecrest
, andfirecrest
aiida-firecrest
by mockingpyfirecrest
only, notfirecrest
server.Current states still depends on un-merged PR#6043, butfunctional with latest features ofaiida v2.5.2