search

aiidateam / aiida-firecrest

AiiDA Transport/Scheduler plugins for interfacing with FirecREST (https://products.cscs.ch/firecrest/)
MIT License
2 stars 3 forks source link

Remove redundant deps pre-commit #44

Closed agoscinski closed 4 months ago

agoscinski commented 4 months ago

Having two places for dependencies create unnecessary redundancy. Better to have everything in the pyproject.toml0 and using this in the CI

I think pinning the python version in the pre-commit file is much of use, but more annoying than helpful, better would pinning package dependency versions.

chrisjsewell commented 4 months ago

Yeh that's not how pre-commit works

agoscinski commented 4 months ago

I am not so familiar with pre-commit, might be that I do something not ideal, but having the same version pinned at multiple locations is definitely not good.

chrisjsewell commented 4 months ago

It creates sandboxed virtual environments, installing into the local environment won't do anything

There is no way to use config from the local repo: https://github.com/pre-commit/pre-commit/issues/3243#issuecomment-2189987115

agoscinski commented 4 months ago

Thanks for the info! I explored a bit some ideas to still remove the redundancy (extracting the version from file, using local repo), but it all seems going in a hacky route that might cause more maintenance problems than it helps, so I just let this go for now.