aiidateam / aiida-firecrest

AiiDA Transport/Scheduler plugins for interfacing with FirecREST (https://products.cscs.ch/firecrest/)
MIT License
2 stars 3 forks source link

`scheduler`: better and more tests #57

Closed khsrali closed 3 months ago

khsrali commented 3 months ago

Changes include:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.32%. Comparing base (a147f87) to head (deb4593). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #57 +/- ## ========================================== - Coverage 79.97% 79.32% -0.65% ========================================== Files 4 4 Lines 674 677 +3 ========================================== - Hits 539 537 -2 - Misses 135 140 +5 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-firecrest/pull/57/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/aiidateam/aiida-firecrest/pull/57/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.32% <100.00%> (-0.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

khsrali commented 3 months ago

Cheers @agoscinski, I applied/answered your suggestions