search

aiidateam / aiida-hyperqueue

AiiDA plugin for the HyperQueue metascheduler.
http://aiida-hyperqueue.readthedocs.io/
MIT License
5 stars 7 forks source link

👌 IMPROVE: Use HQ directives for submit command #1

Open mbercx opened 2 years ago

mbercx commented 2 years ago

The current submit command uses quite a bit of hacky logic to convert the # HQ line into arguments for the hq submit command:

https://github.com/aiidateam/aiida-hyperqueue/blob/3f38f178badf7c1ce7ad28eca105a2bec26af226/aiida_hyperqueue/scheduler.py#L150-L153

Once HQ directives are implemented, as discussed in https://github.com/It4innovations/hyperqueue/issues/6, we can simply add these to separate lines in the jobscript header instead.

giovannipizzi commented 2 years ago

https://github.com/It4innovations/hyperqueue/issues/6 is now fixed! :-) So we can now move fix this issue!

giovannipizzi commented 2 years ago

See also further docs here https://github.com/It4innovations/hyperqueue/pull/330/files; probably we should always submit with the --directives flag to hq submit?