aiidateam / aiida-plugin-cutter

Cookie cutter recipe for AiiDA plugins.
9 stars 12 forks source link

Fix entry point name in `get_computer` #96

Closed lan496 closed 2 years ago

lan496 commented 2 years ago

Since AiiDA>=2.0, all entry points provided by aiida-core start with core. prefix. This commit fixes old entry point names for localhost computer.

See https://aiida.readthedocs.io/projects/aiida-core/en/latest/reference/_changelog.html?highlight=scheduler#plugin-entry-point-updates

ltalirz commented 2 years ago

Thanks for the fix @lan496 and sorry for the delay (busy last week).

The build error of the docs should be fixed by https://github.com/aiidateam/aiida-core/pull/5569; I'm just not sure when I'll find time for finishing the PR

lan496 commented 2 years ago

@ltalirz Thanks for your comment and this nice package to start a plugin development!

ltalirz commented 2 years ago

@lan496 After https://github.com/aiidateam/aiida-core/pull/5657 was merged, the shorthand aliases should now be present in the object.inv of the latest aiida-core documentation build. Let us know whether it works

lan496 commented 2 years ago

@ltalirz Thank you for the information! I have checked the documentation is built without error after updating to aiida-core==2.0.4.