search

aiidateam / aiida-prerequisites

Docker image that contains all prerequisites allowing to run AiiDA.
2 stars 2 forks source link

Syncronize aiida-prerequisites with aiidalab #9

Closed yakutovicha closed 4 years ago

yakutovicha commented 4 years ago
yakutovicha commented 4 years ago

@ltalirz just for your information: I've now setup aiidalab-docker-stack container that works. It is based on this container.

Once the current PR is merged, we can proceed with the PR at aiidalab-docker-stack.

ltalirz commented 4 years ago

@ltalirz just for your information: I've now setup aiidalab-docker-stack container that works. It is based on this container.

Thanks for this! I'm now trying to set up AiiDA lab on an AWS machine to test the AiiDA lab server playbook- happy to switch to your container once it's ready!

ltalirz commented 4 years ago

tests still failing ...

yakutovicha commented 4 years ago

tests still failing ...

fixed

yakutovicha commented 4 years ago

Hi @ltalirz.

I am going to merge this - I've made an issue #10 to address your remaining comment.

yakutovicha commented 4 years ago

Can't we simply check one thing (e.g. if the user exists or not), and if it doesn't, create everything in one go?

It won't always work. If you mount a folder, you still need to go one-by-one and check if things are there. That is why I did it this way.

yakutovicha commented 4 years ago

@ltalirz in the end I decided to add the check you requested. I think it doesn't harm to do it now.

yakutovicha commented 4 years ago

@ltalirz sorry for the mess. I added the requested checks to .travis. No other things were modified. Please have a look and let me know if you agree.