search

aiidateam / aiida-project

AiiDA project manager
Other
3 stars 7 forks source link

✨ NEW: Fish implementation. #9

Closed GeigerJ2 closed 7 months ago

GeigerJ2 commented 1 year ago

Added ShellGenerator class to streamline different shell commands. Currently, it takes the shell_str as instance variable to select the appropriate code, while shell_str and env_file_path are populated in the .format() call when the shell commands are returned. This still seems a bit clunky, any ideas how to improve that?

Added from_env_file classmethod to ProjectConfig to populate config instance from .env file. Renamed set_key/get_key to write_key/read_key.

Instantiation of ProjectConfig passing default arguments of aiida_venv_dir and aiida_project_dir, as setting inside ProjectConfig did not seem to have intended effect?

mbercx commented 8 months ago

@GeigerJ2 thanks for the contribution, and sorry for only coming back to this now... Do you mind if I make some changes directly on top of this PR?

mbercx commented 8 months ago

Was playing around with this and split up the PR in https://github.com/aiidateam/aiida-project/pull/15 and #16. Have a look and let me know what you think!

GeigerJ2 commented 7 months ago

Took it for a spin at the version of PR #16 and everything seemed to work fine. I'm happy with the changes, so we can close this and approve the other ones?