sphuber
commented
1 year ago If all information can be fetched from like https://aiida-pseudo.github.io/ it will be useful.
I agree that this would make it easier to maintain when new versions are released, however, one problem that I see is that now the properly functioning of the package becomes dependent on this online resource functioning properly. If, for whatever reason, the website that stores the list of valid families goes down, the package no longer works.
Moreover, all functionality that need to get a list of available families, for example the CLI commands to install families, will now have to perform an HTTP request just to get the list. So for example, take the option in aiida-pseudo install sssp that denotes the valid versions:https://github.com/aiidateam/aiida-pseudo/blob/1410e6879a38792b5a33515efffa8c2670d7dc40/src/aiida_pseudo/cli/install.py#L185
This will now have to make an HTTP request. It should do so each time the command line is invoked, even just to provide the help string. Of course we can cache the request, but then you have to deal with cache invalidation.
So with all that in mind, for now I would just be tempted to leave it as is. Instead, we should think of upping the version number for aiida-pseudo to v1.0. I think it is being used in production and so can be considered stable enough. This will allow packages downstream to declare aiida-pseudo~=1.0 and they will automatically use a new minor version when we release it with support for a new family. I think the problem currently is that packages are pinning the minor version and we are bumping it for a new family.
What do you think @unkcpz @mbercx ?
mbercx
unkcpz
When a new version of pseudo libraries is released, the package needs to be updated to able to download the new pseudo version. This lead to the issue that having to update aiida-core version in order to install new library version. It seems the pseudos libraries version is bookkeeping in https://github.com/aiidateam/aiida-pseudo/blob/master/src/aiida_pseudo/groups/family/sssp.py for SSSP and https://github.com/aiidateam/aiida-pseudo/blob/master/src/aiida_pseudo/groups/family/pseudo_dojo.py for pseudo-dojo. Probably deserve to move the list and maintain it separately so the old version can download new pseudo libraries.
Here is the commit of changes to update SSSP to v1.2 https://github.com/aiidateam/aiida-pseudo/pull/144/files If all information can be fetched from like https://aiida-pseudo.github.io/ it will be useful.