aiidateam / aiida-pseudo

MIT License
5 stars 8 forks source link

`RecommendedCutoffMixin`: remove units workaround for backwards compatibility #76

Closed mbercx closed 1 year ago

mbercx commented 3 years ago

In #75 we added a workaround to make sure that all pseudo families installed with aiida-pseudo>=0.4.0 would keep on functioning as expected after the introduction of units. Although the workaround is not too "nasty", we should remove it at some point in the future and clean up the code.

The tricky part will be to decide when to remove it, since we can never be sure that all users have updated their pseudo families by reinstalling them or using the get_cutoff_unit method (directly or indirectly). However, there is no rush in removing the workaround, so maybe we can just remove it in the release of v1.0.0. I've opened this issue so we can keep track of this.