aiidateam / aiida-pseudo

MIT License
5 stars 8 forks source link

Install family from a local folder through CLI #79

Closed bosonie closed 3 years ago

bosonie commented 3 years ago

Currently the CLI command aiida-pseudo install family accepts only archives (bztar, gztar, tar, xztar, zip) as valid input arguments (either on the local file system or from URL). It would be nice to allow also the option to pass a standard folder of the local file system. This shouldn't be difficult to implement since the underline method called by the command aiida-pseudo install family is PseudoPotentialFamily.create_from_folder that already accepts directory paths. We should also considering that old commands (like verdi data upf uploadfamily) were supporting this option and therefore a user starting to use the aiida-pseudo commands would expect a similar behavior. In any case, even if this request won't be accepted, I would highly suggest to implement something that improves the error message of the command in the case a repository is passed. In fact, at the moment, one ends up with a raise ValueError("unknown url type: %r" % self.full_url) that is not very clear.