All the base workchains were missing to override the max_iterations input.
The PhBaseWorkChain.get_builder_from_protocol was still untested. Tests are added and the electronic_type input is added as well to allow for the automated/user-friendly computation of dielectric and effective charges tensors when needed (i.e. for insulators).
All the base workchains were missing to override the
max_iterationsinput. ThePhBaseWorkChain.get_builder_from_protocolwas still untested. Tests are added and theelectronic_typeinput is added as well to allow for the automated/user-friendly computation of dielectric and effective charges tensors when needed (i.e. for insulators).