search

aiidateam / aiida-registry

Find plugins for AiiDA
http://aiidateam.github.io/aiida-registry
Other
16 stars 63 forks source link

Separate error prefix message and error message for different formater #285

Closed unkcpz closed 11 months ago

unkcpz commented 12 months ago

This PR contains two changes:

  1. The duplicate item will not add to the errors/warnings list of plugin from installation tests. -> #288
  2. I added support for converting html string to react in showing the plugin checks warning and error messages. The install error message now has a head that shows the cause of the problem and the traceback for the exception of installation and import errors. This is also required by https://github.com/aiidateam/aiida-registry/pull/284 where I want to have a hyperlink to the README to guide the plugin maintainer on how to fix problem.
github-actions[bot] commented 12 months ago

PR Preview Action v1.4.4 :---: :rocket: Deployed preview to https://aiidateam.github.io/aiida-registry/pr-preview/pr-285/ on branch gh-pages at 2023-09-25 02:53 UTC

AhmedBasem20 commented 11 months ago

Thanks @unkcpz, not sure what is the reason for the error duplication, I tried to have a look at the generated JSON file for this PR preview in gh-pages but it is not there. Also at the root gh-pages branch, the last version of https://github.com/aiidateam/aiida-registry/blob/gh-pages/plugins_metadata.json was pushed last week. Is this intended or maybe another issue? Anyway, this is not related to the duplication problem but I think it is good to bring plugins_metadata.json back to gh-pages.

unkcpz commented 11 months ago

Also at the root gh-pages branch, the last version of https://github.com/aiidateam/aiida-registry/blob/gh-pages/plugins_metadata.json was pushed last week. Is this intended or maybe another issue?

I also notice this is quite strange. But I think it is not the cause of the issue. I clean up the cache and it seems all works well now.

AhmedBasem20 commented 11 months ago

I also notice this is quite strange. But I think it is not the cause of the issue. I clean up the cache and it seems all works well now.

Yeah, normally we should see the JSON file for every preview build. so it should be here for example https://github.com/aiidateam/aiida-registry/tree/gh-pages/pr-preview/pr-287

But this is not related to this PR we may open an issue and check this later.

unkcpz commented 11 months ago

Yeah, normally we should see the JSON file for every preview build. so it should be here for example https://github.com/aiidateam/aiida-registry/tree/gh-pages/pr-preview/pr-287

Yes, I noticed it as well but didn't manage to bring the file into gh-pages branch. Let's have a chat to see why I also have other questions in terms of test web build locally.