aiidateam / aiida-restapi

AiiDA Web API for data queries and workflow management.
https://aiida-restapi.readthedocs.io
MIT License
10 stars 7 forks source link

Adds Groups endpoint #20

Closed NinadBhat closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #20 (d97727a) into master (9abe7f7) will increase coverage by 4.91%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   88.88%   93.80%   +4.91%     
==========================================
  Files           6        8       +2     
  Lines         153      226      +73     
==========================================
+ Hits          136      212      +76     
+ Misses         17       14       -3     
Flag Coverage Δ
pytests 93.80% <100.00%> (+4.91%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_restapi/main.py 100.00% <100.00%> (ø)
aiida_restapi/models.py 94.82% <100.00%> (+1.97%) :arrow_up:
aiida_restapi/routers/computers.py 100.00% <100.00%> (ø)
aiida_restapi/routers/groups.py 100.00% <100.00%> (ø)
aiida_restapi/routers/users.py 100.00% <100.00%> (+13.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9abe7f7...d97727a. Read the comment docs.

ltalirz commented 3 years ago

please rebase

ltalirz commented 3 years ago

@NinadBhat thanks for the rebase. I think you should be able to silence this with a # pylint: disable= statement in the file

ltalirz commented 3 years ago

I'm a little confused - it looks almost like you've managed to trip up github's web interface. The file diff shows you adding the Computer model although it's already in master.

I'm going to merge this anyhow, let's see what happens.

ltalirz commented 3 years ago

Seems the actual merge went fine.