search

aiidateam / aiida-restapi

AiiDA Web API for data queries and workflow management.
https://aiida-restapi.readthedocs.io
MIT License
10 stars 7 forks source link

Aiida 2 compatibility #34

Closed ltalirz closed 2 years ago

ltalirz commented 2 years ago

@sphuber tests pass now - if you want to start early, feel free to resolve the conflicts & squash+merge

otherwise happy to take care of it myself

sphuber commented 2 years ago

Seems the codecov step is failing randomly in the ci workflow, it's really annoying. Not sure why that is happening

ltalirz commented 2 years ago

Looks like we're not the only ones seeing this... https://github.com/codecov/codecov-action/issues/557

sphuber commented 2 years ago

yeah, seems rate limiting issue. Recommended action seems to add an explicit token, but not sure if we can generate one. Do we have an account? And does that require paying for the service?

ltalirz commented 2 years ago

I have an account and I'll add the token

sphuber commented 2 years ago

While you're at it, maybe also look into the codecov badge in the README. It currently points to a 404

ltalirz commented 2 years ago

Fixed!

The plugin cutter is using coveralls.io. Historically, both services have had some reliability issues