search

aiidateam / aiida-restapi

AiiDA Web API for data queries and workflow management.
https://aiida-restapi.readthedocs.io
MIT License
9 stars 7 forks source link

DevOps: Fix the continuous-deployment workflow #35

Closed sphuber closed 1 year ago

sphuber commented 1 year ago

The workflow was broken as the check_version.py file was expecting the tag as the last argument to its invocation, but was really receiving the github.ref environment variable which includes the refs/tags/ prefix. The result was that the check for the tag matching the package version would always fail.

The workflow is replaced by one that is tried-and-true in many other repositories of the aiidateam organization.

ltalirz commented 1 year ago

Thanks, could you please remove it from the pre-commit as well?

sphuber commented 1 year ago

I noticed that the pre-commit was still relying on the broken script. I think it is better to adopt PEP 621 first and move to building from pyproject.toml with flit like we do for aiida-core. Then we don't need this consistency check. Will open the PR soon

ltalirz commented 1 year ago

Thanks - I see you opened a separate PR for the first commit; should that one be merged first?

sphuber commented 1 year ago

Thanks - I see you opened a separate PR for the first commit; should that one be merged first?

Yes, this one is a follow-up

codecov-commenter commented 1 year ago

Codecov Report

Base: 93.36% // Head: 93.36% // No change to project coverage :thumbsup:

Coverage data is based on head (4385232) compared to base (d42a28d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #35 +/- ## ======================================= Coverage 93.36% 93.36% ======================================= Files 23 23 Lines 919 919 ======================================= Hits 858 858 Misses 61 61 ``` | Flag | Coverage Δ | | |---|---|---| | pytests | `93.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ltalirz commented 1 year ago

done!