Closed agoscinski closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.39%. Comparing base (
3f14ea2
) to head (a6744e9
). Report is 8 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @agoscinski , thanks for the PR!
Since @unkcpz mentioned wanting to take responsibility for the aiida-restapi in the aiida meeting, I added him as the reviewer here. For the future PR, you can also add him as the reviewer.
After merge got this error
https://github.com/aiidateam/aiida-restapi/actions/runs/9188834086/job/25269509068
Not sure why this did not appear during PR. Hope this fixes it
EDIT: I see it did not fail because of
https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes I will create nonupstream branch to test
EDIT2: Okay with this PR https://github.com/aiidateam/aiida-restapi/pull/68 we can verify that the fix works. As it is a branch on the upstream repository it fails when the token is commented out (see second commit that fails while first commit works)