search

aiidateam / aiida-restapi

AiiDA Web API for data queries and workflow management.
https://aiida-restapi.readthedocs.io
MIT License
10 stars 7 forks source link

Implements `nodes/download_formats` endpoint for the REST API #71

Closed agoscinski closed 1 week ago

agoscinski commented 4 months ago

This is only implemented for the REST API side as it is not clear for me how one could profit from the flexibility of GraphQL with this endpoint. Also an implementation for the GraphQL side would need more time and to push the migration to this new API I would ignore it for the moment.

I moved part of the code of aiida.restapi.common.identifiers and aiida.restapi.common.exceptions to this repo that is required to get all download formats.

Fixes subpoints of issues #69 and #12

Question: PR is ready for a review I only need to fix linter errors. I am getting a bit frustrated fixing linter errors. Can I just open another PR where I change the linter and formatter to ruff with settings of aiida-core so it can automatically fix most issues @eimrek @chrisjsewell? We have to do this at some point in any case when we merge this back to aiida-core.

eimrek commented 4 months ago

thanks @agoscinski. I will test this out when i get a moment.

Regarding linting, yep, i think switching to ruff would be great, feel free to do it in a separate PR.