search

aiidateam / aiida-testing

A pytest plugin to simplify testing of AiiDA plugins.
MIT License
5 stars 6 forks source link

allow '**' in ignore files #25

Closed broeder-j closed 4 years ago

broeder-j commented 4 years ago

Feature request, nice to have.

It would be very nice if one could allow for bash regs in the ignorefile list. example 

ignore_files=['cdn**'] # to ignore files with names cdn01, cdn02, cdn23, ...

(if a code produces an arbitray number of files with certain naming pattern)

Otherwise thanks for your work! Currently everything is working nicely on linux. On mac I had an issue, which I did not yet managed to track down yet.

greschd commented 4 years ago

Should be easy enough to do, using the fnmatch.fnmatchcase to match filenames here: https://github.com/aiidateam/aiida-testing/blob/develop/aiida_testing/mock_code/_cli.py#L54

Do you want to do this?

broeder-j commented 4 years ago

I can do it.

greschd commented 4 years ago

Thanks! Feel free to open a separate issue for the mac problem - maybe it's to do with the use of environment variables to pass arguments to the executable?

greschd commented 4 years ago

Closed in #26.