aiidateam / aiida-testing

A pytest plugin to simplify testing of AiiDA plugins.
MIT License
5 stars 6 forks source link

New attempt at implementing `export_cache` fixture #56

Closed janssenhenning closed 1 year ago

janssenhenning commented 2 years ago

Based on #29

These are improvements on top of the initial export_cache fixtures that were written by me and @PhilippRue to be able to run aiida-fleur and aiida-kkr workflow tests with both aiida v1 and v2.

Notable changes from #29

The ignoring of things like environment_variables_double_quotes is not ideal, but I think being explicit with this is better for now.

ltalirz commented 1 year ago

@janssenhenning are you still planning to complete this PR?

janssenhenning commented 1 year ago

@ltalirz Yes I think this would be useful to finish up, since we already use it with a lot of success for veryfying that our plugins work with aiida 1.0 and 2.0

I cleaned the formatting up a bit and added some explanations to the now quite convoluted mokeypatching code What I'm not quite sure on is how and whether I could write more fine-grained tests for these fixtures

As with #57 I have no idea what to do about the test failures

ltalirz commented 1 year ago

Cheers! I'll try to find the time to have a look at this over the weekend

janssenhenning commented 1 year ago

Superseded by #67