consider renaming entry point prefix

ltalirz commented 4 years ago

The naming of entry points in https://github.com/aiidateam/aiida-wannier90-workflows/blob/4d6e0bbfa18c3b55ea9fbbf57781fe896c125ec2/setup.json#L4-L5

is contrary to the convention used in other plugins.

Consider using wannier90_workflows instead of aiida_wannier90_workflows as a prefix.

E.g. this is the output of verdi plugin list on the Quantum Mobile:

verdi plugin list aiida.workflows
Registered entry points for aiida.workflows:
* aiida_wannier90_workflows.bands
* aiida_wannier90_workflows.wannier90
* castep.altrelax
* castep.base
* castep.relax
* codtools.cif_clean
* cp2k.base
* cp2k.multistage
* ddec.cp2k_ddec
* fleur.band
* fleur.base
* fleur.base_relax
* fleur.corehole
* fleur.create_magnetic
* fleur.dmi
* fleur.dos
* fleur.eos
* fleur.init_cls
* fleur.mae
* fleur.mae_conv
* fleur.relax
* fleur.scf
* fleur.ssdisp
* fleur.ssdisp_conv
* optimize.optimize
* optimize.wrappers.add_inputs
* optimize.wrappers.create_evaluate
* quantumespresso.matdyn.base
* quantumespresso.ph.base
* quantumespresso.pw.band_structure
* quantumespresso.pw.bands
* quantumespresso.pw.base
* quantumespresso.pw.relax
* quantumespresso.q2r.base
* raspa.base
* siesta.bands
* siesta.base
* siesta.stm
* vasp.base
* vasp.legacy.autowindows
* vasp.legacy.nscf
* vasp.legacy.projections
* vasp.legacy.scf
* vasp.legacy.wannier
* vasp.legacy.windows
* vasp.relax
* wannier90.minimal

giovannipizzi commented 4 years ago

I agree - @qiaojunfeng could you please fix this?

qiaojunfeng commented 4 years ago

Thanks! Has been fixed in https://github.com/aiidateam/aiida-wannier90-workflows/commit/10a124c21f6379403c6bfb183b1ccdb0c45dfe37

aiidateam / aiida-wannier90-workflows

consider renaming entry point prefix #1