Enable branch protections

aiidateam / aiida-wannier90

AiiDA plugin for the Wannier90 code

https://aiida-wannier90.readthedocs.io

Other

9 stars 15 forks source link

Enable branch protections #40

Closed greschd closed 5 years ago

greschd commented 5 years ago

@giovannipizzi @normarivano we probably shouldn't push directly to develop, and try to keep the tests we have running. I don't have the necessary permissions, @giovannipizzi can you enable the proper branch protection rules?

giovannipizzi commented 5 years ago

Agreed, this wasn't done on purpose, sorry about that. I'll now protect the branch (I will just check if we can quickly fix the tests first.

giovannipizzi commented 5 years ago

I protected the branch. I didn't set a required test pass because tests are still failing, and I'm not sure why yet. Maybe @greschd you could help us out for this? In the meantime we'll probably make another PR to clean up the previous commits.

giovannipizzi commented 5 years ago

Now that #49 is merged I've activated the requirement that tests need to pass

greschd commented 5 years ago

Sweet 👍