search

aiidateam / aiida-wannier90

AiiDA plugin for the Wannier90 code
https://aiida-wannier90.readthedocs.io
Other
9 stars 15 forks source link

Moving test for input .win to pytest-regressions #54

Closed normarivano closed 5 years ago

normarivano commented 5 years ago

In this way we can drop the .pytest_cache folder

Also, fixed the writer to create the same input in py2 and py3 (the problem was the default number of digits when converting a float, now we are using 18.10f everywhere).

Fixes #53

greschd commented 5 years ago

To make sure the pre-commit tests run, you should run pre-commit install in your local repository, and make sure you have the exact versions specified in the dev extra installed (pip install .[dev]).

greschd commented 5 years ago

Not sure what the other test failures are about - I triggered a build of develop manually here to check if that still works.

giovannipizzi commented 5 years ago

@greschd now the PR works - I'm going to approve it, but if you want to give a look before I merge please let me know, since I co-authored the commit

greschd commented 5 years ago

Very nice, thanks!