Closed superstar54 closed 4 weeks ago
Attention: Patch coverage is 93.20388%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 79.39%. Comparing base (
5937b88
) to head (e358fab
). Report is 28 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
aiida_workgraph/task.py | 90.38% | 5 Missing :warning: |
aiida_workgraph/tasks/builtins.py | 85.71% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I agree, regardless of the debate, good to get the code in for live testing. Maybe experience helps (partially) resolve the debate 🤞
Although there remains some debate over whether to use the
append
orreplace
method for managing thewaiting_on
list, I've decided to proceed with theappend
approach based on my past experiences. We are open to revising this if there is strong opposition.For instance, the code below demonstrates how to append "task1" and "task2" to the
waiting_on
list fortask3
, rather than replacing the existing list with ("task1", "task2"):TaskCollection
Implement a
TaskCollection
to store a collection of tasks. This is used for thewaiting_on
andchildren
attributes of the Task class. For example:waiting_on
Take
waiting_on
as an example:When adding or removing the task, it will check if the task exists or not.
Children
The children attribute is used to assign tasks to a Zone (e.g.,
While
zone orIf
zone). For example,