search

aiidateam / aiida-workgraph

Efficiently design and manage flexible workflows with AiiDA, featuring an interactive GUI, checkpoints, provenance tracking, and remote execution capabilities.
https://aiida-workgraph.readthedocs.io/en/latest/
MIT License
9 stars 5 forks source link

Show timeline of called_process #238

Closed superstar54 closed 3 weeks ago

superstar54 commented 3 weeks ago

In the while zone, tasks repeat several times, however, in the timeline it only shows the time for the last iteration of the task. As show below, there is some missing info between add1 and add2.

Screenshot from 2024-08-18 14-12-06

This PR adds the called_process option. Switching to this option, it will show the timeline for all the processes that called by the WorkGraph: Screenshot from 2024-08-18 14-12-18

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.37%. Comparing base (5937b88) to head (15069d6). Report is 35 commits behind head on main.

Files Patch % Lines
aiida_workgraph/utils/__init__.py 77.27% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #238 +/- ## ========================================== + Coverage 75.75% 79.37% +3.62% ========================================== Files 70 62 -8 Lines 4615 4567 -48 ========================================== + Hits 3496 3625 +129 + Misses 1119 942 -177 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/238/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.24% <77.27%> (+3.57%)` | :arrow_up: | | [python-3.12](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.26% <77.27%> (?)` | | | [python-3.9](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/238/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.30% <77.27%> (+3.57%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superstar54 commented 3 weeks ago

Hi @agoscinski , the frontend test caught a bug in this PR. https://github.com/aiidateam/aiida-workgraph/actions/runs/10441999297/job/28914107364

Very helpful!