Open superstar54 opened 3 weeks ago
Attention: Patch coverage is 34.32836%
with 44 lines
in your changes missing coverage. Please review.
Project coverage is 79.08%. Comparing base (
5937b88
) to head (7f5acd2
). Report is 50 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
aiida_workgraph/engine/utils.py | 39.39% | 20 Missing :warning: |
aiida_workgraph/engine/workgraph.py | 29.16% | 17 Missing :warning: |
aiida_workgraph/decorator.py | 30.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @mbercx , I've created a submission controller using WorkGraph. Could you please review the example above and let me know if it makes sense to you? I'd appreciate your feedback.
This PR adds an
awatiable_builder
decorator; the decorated function will submit an AiiDA Process and return the ProcessNode.Note: The user needs to use the modified
submit
(from aiida_workgraph.engine.utils import submit
), so that the task can submit the process inside the WorkGraph without using theself.submit
.The primary purpose is to allow the WorkGraph to submit other jobs.
submission_controller
using WorkGraph.Here is an example to submit the PW calculation for a list of structures inside a AiiDA group. The maximum running process is set to 2. Similar to this example from aiida-submission-controller.
WorkGraph
Timeline
We can see that the maximum number of running processes is 2 for all the time.
The examples can be found here:https://github.com/superstar54/aiida-submission-controller/blob/feature/workgraph/examples/workgraph_group.py