codecov-commenter
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.62%. Comparing base (
5937b88) to head (9842670). Report is 79 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #287 +/- ## ========================================== + Coverage 75.75% 80.62% +4.87% ========================================== Files 70 66 -4 Lines 4615 5147 +532 ========================================== + Hits 3496 4150 +654 + Misses 1119 997 -122 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/287/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.55% <ø> (+4.88%)` | :arrow_up: | | [python-3.12](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.55% <ø> (?)` | | | [python-3.9](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/287/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.58% <ø> (+4.84%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Implements suggestions in issue https://github.com/aiidateam/aiida-workgraph/issues/284
~@superstar54 I have an issue with
submit(wait=True)the output is None (see first example where I kept submit).~ EDIT: I see that this is something related to my local setup and not a general bug.While I think the section about nested data types at the end is important, it does not really fit into the aggregate notebook. It is also more dealing with aiida-core issues than workgraph. I have no good idea at the moment. I would keep it there and see if we can move it somewhere more meaningful in the future.