search

aiidateam / aiida-workgraph

Efficiently design and manage flexible workflows with AiiDA, featuring an interactive GUI, checkpoints, provenance tracking, and remote execution capabilities.
https://aiida-workgraph.readthedocs.io/en/latest/
MIT License
10 stars 5 forks source link

Use type_mapping from aiida-workgraph #294

Closed superstar54 closed 2 months ago

superstar54 commented 2 months ago

aiida-workgraph borrows some socket type from the node-graph package, which make it hard to control the property of the socket.

This PR removes all socket types from node-graph.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 86.20690% with 12 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (5937b88) to head (085aa1d). Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/properties/builtins.py 79.62% 11 Missing :warning:
tests/test_socket.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #294 +/- ## ========================================== + Coverage 75.75% 79.99% +4.23% ========================================== Files 70 65 -5 Lines 4615 4998 +383 ========================================== + Hits 3496 3998 +502 + Misses 1119 1000 -119 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/294/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.91% <86.20%> (+4.24%)` | :arrow_up: | | [python-3.12](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.91% <86.20%> (?)` | | | [python-3.9](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/294/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `79.94% <86.20%> (+4.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superstar54 commented 2 months ago

Why the bump to node-graph v0.0.17? Is this just a side thing, or does it have deeper meaning?

I updated the node-graph to support passing type_mapping as an argument when creating the task. So this is needed.