aiidateam / aiida-workgraph

Efficiently design and manage flexible workflows with AiiDA, featuring an interactive GUI, checkpoints, provenance tracking, and remote execution capabilities.
https://aiida-workgraph.readthedocs.io/en/latest/
MIT License
10 stars 5 forks source link

add padding for scope #331

Closed superstar54 closed 2 months ago

superstar54 commented 2 months ago

Defines custom padding for a scope layout. The padding values are used by the ScopesPlugin to avoid node overlapping with the socket of the parent node. Before, the conditions socket overlaps with task:

Screenshot from 2024-09-20 10-01-05

After: Screenshot from 2024-09-20 09-56-02

Note: we need to update three places: 1) web app, 2) widget 3) HTML template. This is not good; we need to refactor the code in the future so that we create a library for all.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.62%. Comparing base (5937b88) to head (d190519). Report is 79 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #331 +/- ## ========================================== + Coverage 75.75% 80.62% +4.87% ========================================== Files 70 66 -4 Lines 4615 5147 +532 ========================================== + Hits 3496 4150 +654 + Misses 1119 997 -122 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/331/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.55% <ø> (+4.88%)` | :arrow_up: | | [python-3.12](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.55% <ø> (?)` | | | [python-3.9](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/331/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.58% <ø> (+4.84%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

superstar54 commented 2 months ago

Can you make a note in some issue referencing this PR or open a new issue to just keep track of it?

Yes, I created an issue