search

aiidateam / aiida-workgraph

Efficiently design and manage flexible workflows with AiiDA, featuring an interactive GUI, checkpoints, provenance tracking, and remote execution capabilities.
https://aiida-workgraph.readthedocs.io/en/latest/
MIT License
10 stars 5 forks source link

Add _wait Socket for Context Transitions and Fix Allowed Types for AiiDA Property #339

Closed superstar54 closed 1 month ago

superstar54 commented 1 month ago

This PR includes two fixes:

  1. Add _wait socket for both from_context and to_context.
  2. Resolves an issue with the allowed_types specification in AiiDA properties to allow setting value from context.
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (5937b88) to head (399915c). Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_socket.py 92.85% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #339 +/- ## ========================================== + Coverage 75.75% 80.66% +4.91% ========================================== Files 70 66 -4 Lines 4615 5156 +541 ========================================== + Hits 3496 4159 +663 + Misses 1119 997 -122 ``` | [Flag](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/339/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | Coverage Δ | | |---|---|---| | [python-3.11](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.58% <95.83%> (+4.91%)` | :arrow_up: | | [python-3.12](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.58% <95.83%> (?)` | | | [python-3.9](https://app.codecov.io/gh/aiidateam/aiida-workgraph/pull/339/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam) | `80.62% <95.83%> (+4.88%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aiidateam#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.