Closed giovannipizzi closed 3 years ago
Note: once it's merged in master, I will tag it, release it on pypi and merge back in develop
Merging #103 (02caddd) into master (c718ffd) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 7
Lines 1199 1541 +342
==========================================
+ Hits 1199 1541 +342
Impacted Files | Coverage Δ | |
---|---|---|
disk_objectstore/__init__.py | 100.00% <100.00%> (ø) |
|
disk_objectstore/container.py | 100.00% <100.00%> (ø) |
|
disk_objectstore/utils.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c718ffd...02caddd. Read the comment docs.
You might also want to consider integrating the PyPi release into GitHub actions:
publish:
name: Publish to PyPi
needs: [pre-commit, tests]
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags')
runs-on: ubuntu-latest
steps:
- name: Checkout source
uses: actions/checkout@v2
- name: Set up Python 3.7
uses: actions/setup-python@v1
with:
python-version: 3.7
- name: Build package
run: |
pip install wheel
python setup.py sdist bdist_wheel
- name: Publish
uses: pypa/gh-action-pypi-publish@v1.1.0
with:
user: __token__
password: ${{ secrets.PYPI_KEY }}
I finally got to add the changelog. I think from now on it's enough to just mention the month (the exact date is anyway in the git history). Ready to be merged for me, please let me know when it's done so I release (thanks @chrisjsewell for the hints - I think we can improve the release cycle in the future, maybe you're right that it's more complex than needed, I'm just used to it so I try to do the same in all repos, but we can definitely improve for the future versions).
export
, implementimport_objects
function instead on the other side (more efficient)