aiidateam / disk-objectstore

An implementation of an efficient "object store" (actually, a key-value store) writing files on disk and not requiring a running server
https://disk-objectstore.readthedocs.io
MIT License
16 stars 8 forks source link

Moving documentation to sphinx+myst #127

Closed giovannipizzi closed 2 years ago

giovannipizzi commented 2 years ago

The content has been moved from the README to the documentation. Note that this is not yet on RTD (so some links might be broken). If the PR is OK, we can merge it and I setup the RTD project?

@chrisjsewell this is my first time with sphinx+myst, so feedback welcome

codecov[bot] commented 2 years ago

Codecov Report

Merging #127 (b8caf44) into develop (7a09ea2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #127   +/-   ##
========================================
  Coverage    99.52%   99.52%           
========================================
  Files            8        8           
  Lines         1675     1675           
========================================
  Hits          1667     1667           
  Misses           8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a09ea2...b8caf44. Read the comment docs.

chrisjsewell commented 2 years ago

Note that this is not yet on RTD (so some links might be broken). If the PR is OK, we can merge it and I setup the RTD project?

Just set up RTD, add a .readthedocs.yaml, and it'll build it for this PR

giovannipizzi commented 2 years ago

https://disk-objectstore.readthedocs.io/en/latest/ seems to exist anymore, did you create it? I cannot find in the aiida RTD account (nor in mine)

chrisjsewell commented 2 years ago

Just set up RTD

did you create it?

chrisjsewell commented 2 years ago

You'll see its in the PR checks now

giovannipizzi commented 2 years ago

Thanks! What's the best way to get the version in conf.py? At the moment I import disk_objectstore that is clearly not installed. Should I play with the path (sys.path.append('..') or similar) or there are better ways?

giovannipizzi commented 2 years ago

Ok, everything fixed, now this is ready to be merged!